Skip to content
This repository was archived by the owner on Mar 5, 2026. It is now read-only.

Remove potential infinite init loop#2577

Merged
mkondratek merged 2 commits intomainfrom
mkondratek/fix/init-loop
Nov 4, 2024
Merged

Remove potential infinite init loop#2577
mkondratek merged 2 commits intomainfrom
mkondratek/fix/init-loop

Conversation

@mkondratek
Copy link
Copy Markdown
Contributor

@mkondratek mkondratek commented Nov 4, 2024

Accidentally, I found an infinite loop in cody tool window content initialization. It was likely a reason of the recent CI failures. This PR eliminates the risk of the inifinite loop.

Test plan

  1. Run integrationTests locally - should be all green, no sus logs, or errros indicating a loop in call stack

@mkondratek mkondratek self-assigned this Nov 4, 2024
}

toolWindow.setAdditionalGearActions(customCodySettings);

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice find!

Copy link
Copy Markdown
Contributor

@pkukielka pkukielka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@mkondratek mkondratek merged commit bc926d1 into main Nov 4, 2024
@mkondratek mkondratek deleted the mkondratek/fix/init-loop branch November 4, 2024 15:00
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants