Skip to content
This repository was archived by the owner on Mar 5, 2026. It is now read-only.

Fix Container is already disposed from withAgent#2597

Merged
mkondratek merged 2 commits intomainfrom
mkondratek/fix/disposed-error
Nov 8, 2024
Merged

Fix Container is already disposed from withAgent#2597
mkondratek merged 2 commits intomainfrom
mkondratek/fix/disposed-error

Conversation

@mkondratek
Copy link
Copy Markdown
Contributor

@mkondratek mkondratek commented Nov 7, 2024

We received multiple reports of #2517.
This PR fixes #2517.

Test plan

I was not able to reproduce it. I tried closing and opening the project quickly. Tried switching projects too. No success.

@mkondratek mkondratek self-assigned this Nov 7, 2024
@mkondratek mkondratek changed the title Remove redundant methods Fix Container is already disposed from withAgent Nov 7, 2024
This was referenced Nov 7, 2024
This was referenced Nov 7, 2024
if (CodyApplicationSettings.instance.isCodyEnabled) {
ApplicationManager.getApplication().executeOnPooledThread {
try {
if (project.isDisposed) return@executeOnPooledThread
Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the fix

@mkondratek mkondratek enabled auto-merge (squash) November 7, 2024 22:15
Copy link
Copy Markdown
Contributor

@pkukielka pkukielka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mkondratek mkondratek merged commit 417444a into main Nov 8, 2024
@mkondratek mkondratek deleted the mkondratek/fix/disposed-error branch November 8, 2024 08:32
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

bug: com.intellij.serviceContainer.AlreadyDisposedException: Container is already disposed

2 participants