This repository was archived by the owner on Mar 5, 2026. It is now read-only.
Merged
Conversation
mkondratek
changed the title
mkondratek
commented
Nov 13, 2024
| val contentChanges: List<ProtocolTextDocumentContentChangeEvent>? = null, | ||
| val testing: TestingParams? = null, | ||
| ) { | ||
| class ProtocolTextDocumentUtil { |
Contributor
Author
There was a problem hiding this comment.
Again, we may want to reconsider the naming. But I'd rather migrate the API quickly and apply the other improvements later.
pkukielka
reviewed
Nov 13, 2024
| ideVersion = ApplicationInfo.getInstance().build.toString(), | ||
| workspaceRootUri = | ||
| ProtocolTextDocument.normalizeUriOrPath( | ||
| ProtocolTextDocumentUtil.normalizeUriOrPath( |
Contributor
There was a problem hiding this comment.
Why not put it in the protocol_extensions and use the existing extension pattern?
Then you won't need all those renames.
Contributor
Author
There was a problem hiding this comment.
These methods are not extension functions in Kotlin sense. However, I did some refactor and it should look better now.
Contributor
Author
There was a problem hiding this comment.
In particular. I cannot define the other class named ProtocolTextDocument since there is one generated already.
mkondratek
force-pushed
the
mkondratek/chore/migrate-api-part-2
branch
from
63afb4c to
673dacb
Compare
mkondratek
force-pushed
the
mkondratek/chore/migrate-api-part-2
branch
from
673dacb to
f20f828
Compare
pkukielka
reviewed
Nov 13, 2024
| @@ -0,0 +1,6 @@ | |||
| package com.sourcegraph.cody.agent.protocol_extensions | |||
|
|
|||
| object TestingParamsUtil { | |||
Contributor
There was a problem hiding this comment.
Could also be TestingParamsExt for consistency
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is a part of the protocol migration. Some endpoints are written by hand. We are switching to the protocol generated from Cody. In this PR:
Based on PR #2632
Full chain of PRs as of 2024-11-13
mkondratek/chore/migrate-api-part-2➔mkondratek/chore/migrate-api-part-1mkondratek/chore/migrate-api-part-1➔mkondratek/chore/update-depsmkondratek/chore/update-deps➔mainTest plan