This repository was archived by the owner on Mar 5, 2026. It is now read-only.
Migrate editTask/*, editCommands/code, webview/*, chat/web/new#2637
Merged
mkondratek merged 6 commits intomainfrom Nov 14, 2024
Merged
Migrate editTask/*, editCommands/code, webview/*, chat/web/new#2637mkondratek merged 6 commits intomainfrom
mkondratek merged 6 commits intomainfrom
Conversation
mkondratek
changed the title
mkondratek
commented
Nov 13, 2024
|
|
||
| implementation("com.typesafe:config:1.4.3") | ||
| implementation("org.eclipse.lsp4j:org.eclipse.lsp4j.jsonrpc:0.23.1") | ||
| testImplementation("net.java.dev.jna:jna:5.10.0") // it is needed for integration tests |
Contributor
Author
There was a problem hiding this comment.
surprise 🎉 we still need it to run IT locally
mkondratek
commented
Nov 13, 2024
| .rows(15) | ||
| .bindText(IgnoreOverrideModel::policy) | ||
| .validationInfo { textArea -> | ||
| .validationOnInput { textArea -> |
Contributor
Author
There was a problem hiding this comment.
minor fix (now the json error is shown on input change
mkondratek
commented
Nov 13, 2024
| } | ||
|
|
||
| override fun doOKAction() { | ||
| super.doOKAction() |
Contributor
Author
There was a problem hiding this comment.
it was a bug, the values were always from before the change. rather small impact tho as we use it only for our testing.
This was referenced Nov 13, 2024
Merged
Closed
mkondratek
added a commit
that referenced
this pull request
Nov 14, 2024
This PR is a part of the protocol migration. Some endpoints are written by hand. We are switching to the protocol generated from Cody. In this PR: - [Migrate ignore/test](03a93bf) <!-- start git-machete generated --> # Based on PR #2637 ## Full chain of PRs as of 2024-11-13 * PR #2638: `mkondratek/chore/migrate-api-part-4` ➔ `mkondratek/chore/migrate-api-part-3x` * PR #2637: `mkondratek/chore/migrate-api-part-3x` ➔ `main` <!-- end git-machete generated --> ## Test plan - All migrated endpoints have been verified with debugger (and reviewed in the trace log). - Cody Ignore (with `CODY_JETBRAINS_FEATURES=cody.feature.internals-menu=true`) 🟢
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is a part of the protocol migration. Some endpoints are written by hand. We are switching to the protocol generated from Cody. In this PR:
Test plan