This repository was archived by the owner on Mar 5, 2026. It is now read-only.
Restart Cody in case of webview renderer crash#2645
Merged
Conversation
pkukielka
force-pushed
the
pkukielka/implement-webview-restart
branch
from
be166fe to
6f1624e
Compare
pkukielka
force-pushed
the
pkukielka/implement-webview-restart
branch
from
6f1624e to
8b96605
Compare
mkondratek
reviewed
Nov 15, 2024
| SSL Info: $sslInfo""" | ||
| .trimIndent()) | ||
| ProjectManager.getInstance().openProjects.forEach { project -> | ||
| TelemetryV2.sendTelemetryEvent(project, "cody.webview.request", "certError") |
mkondratek
approved these changes
Nov 15, 2024
Comment on lines
-404
to
-406
| // TODO: Add Telemetry here. | ||
| // TODO: Logging. | ||
| // TODO: Trigger a reload. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Looks like webview renderer process crashes from time to time for some users - especially in cases like long running IDE or suspending/unsuspending OS.
We might not be able to fully fix the root cause, but we should handle the crash and recover from it.
For now, I'm just restarting the agent which also restarts the webview.
I was trying to only restart the webviews and keep the agent running, but I did not managed to do it on the first try.
Let's merge this as it improves current situation significantly, and I will work on better/quicker restoration of the state in the followup PR(s).
Test plan
jcef Helper (Renderer)