This repository was archived by the owner on Mar 5, 2026. It is now read-only.
Merged
Conversation
mkondratek
commented
Nov 18, 2024
| nodeBinaries.commit=8755ae4c05fd476cd23f2972049111ba436c86d4 | ||
| nodeBinaries.version=v20.12.2 | ||
| cody.autocomplete.enableFormatting=true | ||
| cody.commit=6ac4a8c1831ad3945fc16f20b8f21947897d3d14 |
Contributor
Author
There was a problem hiding this comment.
- wait for https://github.com/sourcegraph/cody/pull/6144 and and for the release including the change
- update cody commit
mkondratek
commented
Nov 18, 2024
|
|
||
| public static final int spaceBetweenButtons = 5; | ||
|
|
||
| public static volatile String lastCopiedText = null; |
Contributor
Author
There was a problem hiding this comment.
It looks like since we have moved to webview we do not set this value. Hence, we do not log the paste event.
Or at any chance, does the agent handle the paste event? If it does not, we probably need to send the copied text via a notification to the client to track it in here.
Contributor
There was a problem hiding this comment.
mkondratek
force-pushed
the
mkondratek/chore/migrate-api-telemetry
branch
3 times, most recently
from
4991dc9 to
2d4a79f
Compare
mkondratek
added a commit
to sourcegraph/cody-public-snapshot
that referenced
this pull request
Nov 18, 2024
This change is required for the ongoing migration to the generated API in the JetBrains client. Related PR: sourcegraph/jetbrains#2661 Some more advanced types are skipped to simplify the code gen. We used internal types too casually. We should be more precise about the protocol. Related thread: https://sourcegraph.slack.com/archives/C05AGQYD528/p1728049089597009 ## Test plan <!-- Required. See https://docs-legacy.sourcegraph.com/dev/background-information/testing_principles. --> Verified with JB. Telemetry goes through the API. ## Changelog <!-- OPTIONAL; info at https://www.notion.so/sourcegraph/Writing-a-changelog-entry-dd997f411d524caabf0d8d38a24a878c -->
mkondratek
force-pushed
the
mkondratek/chore/migrate-api-telemetry
branch
from
f4168ad to
28368da
Compare
mkondratek
force-pushed
the
mkondratek/chore/migrate-api-telemetry
branch
from
28368da to
ca46fca
Compare
mkondratek
force-pushed
the
mkondratek/chore/migrate-api-telemetry
branch
from
ca46fca to
485934a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is a part of the protocol migration. Some endpoints are written by hand. We are switching to the protocol generated from Cody. In this PR:
Test plan