Skip to content

sentrycore: wrap error with log message#2

Merged
bobheadxi merged 2 commits intomainfrom
sentry/better-erorr-message
Jun 13, 2022
Merged

sentrycore: wrap error with log message#2
bobheadxi merged 2 commits intomainfrom
sentry/better-erorr-message

Conversation

@bobheadxi
Copy link
Member

@bobheadxi bobheadxi commented Jun 10, 2022

Right now, error messages are super non-descript because most context is in the log message, not in the error message. I think it's useful to have the log message here because it also matters where each error is being reported from, so grouping by log messages is something we probably want.

And of course we add the scope, because we want those to become important keys in navigating observability reports.

image

@bobheadxi bobheadxi requested review from a team and jhchabran June 10, 2022 23:48
@codecov-commenter
Copy link

Codecov Report

Merging #2 (f747bb5) into main (4de9057) will increase coverage by 0.56%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main       #2      +/-   ##
==========================================
+ Coverage   56.63%   57.19%   +0.56%     
==========================================
  Files          13       13              
  Lines         535      542       +7     
==========================================
+ Hits          303      310       +7     
  Misses        222      222              
  Partials       10       10              
Impacted Files Coverage Δ
internal/sinkcores/sentrycore/worker.go 80.43% <100.00%> (+1.61%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4de9057...f747bb5. Read the comment docs.

Copy link
Contributor

@jhchabran jhchabran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good call!

@bobheadxi bobheadxi merged commit 727b7a7 into main Jun 13, 2022
@bobheadxi bobheadxi deleted the sentry/better-erorr-message branch June 13, 2022 15:06
bobheadxi added a commit to sourcegraph/sourcegraph-public-snapshot that referenced this pull request Jun 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants