Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## main #2 +/- ##
==========================================
+ Coverage 56.63% 57.19% +0.56%
==========================================
Files 13 13
Lines 535 542 +7
==========================================
+ Hits 303 310 +7
Misses 222 222
Partials 10 10
Continue to review full report at Codecov.
|
bobheadxi
added a commit
to sourcegraph/sourcegraph-public-snapshot
that referenced
this pull request
Jun 14, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Right now, error messages are super non-descript because most context is in the log message, not in the error message. I think it's useful to have the log message here because it also matters where each error is being reported from, so grouping by log messages is something we probably want.
And of course we add the scope, because we want those to become important keys in navigating observability reports.