This repository was archived by the owner on Apr 25, 2023. It is now read-only.
lsif-clang: Reduce contention by using per-table mutexes. #85
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For an indexing job of CMake on a 60 core machine: - Before this change: indexing time 30s with about 31/60 core utilization - After this change: indexing time 25s with about 42/60 core utilization There doesn't seem to be much effect on 16 core machines. This was changed in upstream LLVM too (in clangd). The patch to IndexerMain.cpp is not used, because the code is duplicated in LSIFClangMain.cpp, but we keep the two in sync.
Contributor
Author
|
Looks like there was another optimization around files in the upstream commit which introduced this. |
Contributor
Author
|
Updated benchmarks with the file optimization: (different 60 core instance)
|
This cuts down build time further by about 40% for CMake.
jlisee
pushed a commit
to jlisee/lsif-clang
that referenced
this pull request
Jul 8, 2022
…aph#85) * lsif-clang: Reduce contention by using per-table mutexes. For an indexing job of CMake on a 60 core machine: - Before this change: indexing time 30s with about 31/60 core utilization - After this change: indexing time 25s with about 42/60 core utilization There doesn't seem to be much effect on 16 core machines. This was changed in upstream LLVM too (in clangd). The patch to IndexerMain.cpp is not used, because the code is duplicated in LSIFClangMain.cpp, but we keep the two in sync. * lsif-clang: Add file skipping optimization from upstream patch. This cuts down build time further by about 40% for CMake. Practically a cherry-pick of 9cb00e7133ea3da6a49ade95e3708240c2aaae39
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For an indexing job of CMake on a 60 core machine:
There doesn't seem to be much effect on 16 core machines.
This was changed in upstream LLVM too (in clangd).
The code change to IndexerMain.cpp is redundant, because the code is
duplicated in LSIFClangMain.cpp, but we keep the two in sync.
Test plan
Manually tested