Provider: add linear-docs provider#126
Merged
valerybugakov merged 1 commit intomainfrom Jun 6, 2024
Merged
Conversation
toolmantim
reviewed
Jun 5, 2024
| @@ -0,0 +1,111 @@ | |||
| // Identical to provider/linear-issues/auth.ts. | |||
Collaborator
There was a problem hiding this comment.
If this is identical, should we just created a shared lib file for them, or import one from the other?
Member
Author
There was a problem hiding this comment.
I thought about it but decided to keep it simple for now with code duplication. I do not expect this code (local auth scripts) to be changed. WDYT?
Collaborator
There was a problem hiding this comment.
It's a fair whack of code… but we don't have CI that runs across both if you just intend on changing one… so probably not a bad idea to keep separate.
toolmantim
approved these changes
Jun 6, 2024
| @@ -0,0 +1,111 @@ | |||
| // Identical to provider/linear-issues/auth.ts. | |||
Collaborator
There was a problem hiding this comment.
It's a fair whack of code… but we don't have CI that runs across both if you just intend on changing one… so probably not a bad idea to keep separate.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Test plan
bundle.jsfile.