pass settings in all HTTP provider invocations#210
Merged
Conversation
The spec says that HTTP providers are invoked with a POST whose body includes the settings (https://openctx.org/docs/protocol). However, this was not happening; only the `params` were being sent. This fix makes it so that the `settings` are also passed.
mmanela
approved these changes
Oct 25, 2024
0xnmn
approved these changes
Oct 25, 2024
Contributor
0xnmn
left a comment
0xnmn
left a comment
There was a problem hiding this comment.
LGTM. Do we have any user using a HTTP provider btw?
Contributor
|
@sqs this would need a followup version bump and publish. I am out right now, so can't do it. |
sqs
added a commit
to sourcegraph/cody-public-snapshot
that referenced
this pull request
Oct 28, 2024
sqs
added a commit
to sourcegraph/cody-public-snapshot
that referenced
this pull request
Oct 28, 2024
Incorporates sourcegraph/openctx#210. ## Test plan CI
bevzzz
pushed a commit
to bevzzz/openctx
that referenced
this pull request
Dec 12, 2024
The spec says that HTTP providers are invoked with a POST whose body includes the settings (https://openctx.org/docs/protocol). However, this was not happening; only the `params` were being sent. This fix makes it so that the `settings` are also passed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The spec says that HTTP providers are invoked with a POST whose body includes the settings (https://openctx.org/docs/protocol). However, this was not happening; only the
paramswere being sent. This fix makes it so that thesettingsare also passed.