Return non-zero exit code when missing SemanticDB files #332
Conversation
Previously, `lsif-java index` would occasionally return a successful exit code even if it didn't produce a `dump.lsif` file. Now, it should return the exit code 1 instead in these scenarios.
| } | ||
| CommandResult(0, Nil) | ||
| } | ||
| CommandResult(0, Nil) | ||
| } | ||
|
|
There was a problem hiding this comment.
Im confused about this, does not returning an explicit CommandResult result in the exit code being set to non-zero?
There was a problem hiding this comment.
The CommandResult on line 162 was previously discarded because the if/else wasn't the last statement
There was a problem hiding this comment.
oh so thats a thing in scala 🤔 TIL
There was a problem hiding this comment.
There are compiler flags to turn that into an error but I don't like using it because there are too many false positives (lots of side-effecting methods return non-Unit values)
There was a problem hiding this comment.
I probably messed up because I've been writing too much Java/Go lately with early returns. I don't remember being hit by this in the past, it's usually a non-issue in my experience.
There was a problem hiding this comment.
It mightve been introduced by me here
There was a problem hiding this comment.
Aha, hehe looks like that indeed 😜
2 participants
Previously,
lsif-java indexwould occasionally return a successfulexit code even if it didn't produce a
dump.lsiffile. Now, it shouldreturn the exit code 1 instead in these scenarios.