Index SemanticDB synthetics #342
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, lsif-java only indexed the "Occurrences" section of a SemanticDB `TextDocument`. Now, we additionall index the "Synthetics" section, which includes inferred expression from Scala implicits, for comprehensions, `.apply` methods and more. The benefit of this fix is that "find references" on an implicit or an `apply` method now shows usages where those symbols got inferred (the user didn't explicitly write a reference to them). It could be that this fix alone is not sufficient to enable "find references" to show results on Sourcegraph. The Sourcegraph backend will also need to accept offset ranges with zero length.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, lsif-java only indexed the "Occurrences" section of a
SemanticDB
TextDocument. Now, we additionall index the "Synthetics"section, which includes inferred expression from Scala implicits, for
comprehensions,
.applymethods and more. The benefit of this fix isthat "find references" on an implicit or an
applymethod now showsusages where those symbols got inferred (the user didn't explicitly
write a reference to them).
It could be that this fix alone is not sufficient to enable "find
references" to show results on Sourcegraph. The Sourcegraph backend
will also need to accept offset ranges with zero length.
Fixes #340