Drop ZINC/SBT URI scheme and prune dead helpers#895
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two small, independent cleanups that don't depend on any in-flight work.
Drop ZINC/SBT URI scheme
Scala/SBT support was dropped in #883, but the SBT-via-Zinc plumbing in the javac plugin lingered:
UriScheme.SBT(already@Deprecated) andUriScheme.ZINC-build-tool:sbtargument parsingvf://tmp/URI handling inSemanticdbTaskListener.absolutePathFromUriThe
minimizedsbt project was the last user of-build-tool:sbt. Updated it to fork javac with--add-exportsflags (same tricksemanticdbKotlincMinimizedalready uses), so the plugin sees real file paths instead of sbt'svf://virtual-file URIs.Remove dead helpers and unused imports
Pure dead-code removal:
Result.{fold,map,isError,equals,hashCode,toString}— none called externally;maponly calledfoldrecursively. ImprovedgetOrThrow/getErrorOrThrowerror messages and madekindfinal.GlobalSymbolsCache.isNone— single-line wrapper forsym == null, inlined into its sole caller; dropped now-unusedElementKindimport.AnalyzerCheckers.kt(kotlin.math.exp,FirBasicExpressionChecker,FirClassReferenceExpressionChecker,FirClassReferenceExpression,FirStatement,coneType,resolvedType).Validation
sbt checkAll✅sbt unit/test✅sbt snapshots/test✅ (no snapshot drift)sbt minimized/clean minimized/compile✅sbt semanticdbKotlincMinimized/clean kotlincSnapshots✅ (no snapshot drift)