Drop SemanticdbAgent, PackageHub, and other dead code paths#902
Merged
Conversation
- Delete the semanticdb-agent module and its in-Gradle fallback (the ByteBuddy advice that injected -Xplugin:semanticdb when the normal compileOnly attachment didn't reach javac). - Add a post-build diagnostic in GradleBuildTool that surfaces a clear actionable error when Gradle finishes successfully but produces no .semanticdb files (the case the agent used to silently rescue). - Delete dead Gradle toolchain code: GradleJavaCompiler, GradleJavaToolchains.fromWorkspace, paths(), executableJavacPath(), and the printDebugLogs helper they fed. - Drop PackageHub support: hidden --packagehub flag on the CLI, the HTTP POST plumbing, and the com.lihaoyi:requests dependency. - Drop the broken nativeImageProfiled sbt command (no GraalVM plugin). - Drop the orphan bin/packagehub.sh script. - Inline CommentSyntax into ScipPrinters (4-entry map, no codec needed).
This reverts commit 97e507c.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.