Skip to content

Conversation

@felixfbecker
Copy link
Contributor

@felixfbecker felixfbecker commented Apr 13, 2020

Action items withou a command are not valid according to our schema and cause user confusion (https://github.com/sourcegraph/sourcegraph/issues/5488). This gives the action item a valid purpose: Jumping to the resolved code owner file at the exact line of the resolved pattern.

@felixfbecker felixfbecker requested a review from a team April 13, 2020 09:25
@felixfbecker felixfbecker force-pushed the jump-to-pattern-line branch from ad61046 to 4212ca0 Compare April 13, 2020 12:36
@felixfbecker felixfbecker force-pushed the jump-to-pattern-line branch from 4212ca0 to bcb649e Compare April 13, 2020 12:37
Copy link
Member

@eseliger eseliger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good, cool idea :)

@codecov-io
Copy link

codecov-io commented Apr 13, 2020

Codecov Report

Merging #30 into master will increase coverage by 0.94%.
The diff coverage is 8.69%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master     #30      +/-   ##
=========================================
+ Coverage    7.01%   7.96%   +0.94%     
=========================================
  Files           5       5              
  Lines         114     113       -1     
  Branches       22      24       +2     
=========================================
+ Hits            8       9       +1     
+ Misses        106     104       -2     
Impacted Files Coverage Δ
src/codeownersFile.ts 0.00% <0.00%> (ø)
src/extension.ts 0.00% <0.00%> (ø)
src/uri.ts 0.00% <0.00%> (ø)
src/codeOwners.ts 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8dfad3d...bcb649e. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants