Add version number and better error handling #4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
mike-r-mclaughlin
commented
Oct 27, 2021
mike-r-mclaughlin
commented
- Pulled the SHA to use as a version number from the url field in the manifest
- Include that version number in the bundle file
- Updated the publish script to look for a file with the given version number
- Improve the error handling so all errors from server are printed to screen so it's clear why the publish failed
tjkandala
approved these changes
Oct 27, 2021
Comment on lines
+5
to
+6
| * "https://sourcegraph.com/-/static/extension/13212-sourcegraph-verilog.js?cf8s0z1vs41c--sourcegraph-verilog" | ||
| * @return string version |
There was a problem hiding this comment.
Note: the number 13212 here seems to be the "version" (release ID), while the string we use (cf8s0z1vs41c) is the timestamp at release. For our purpose, I think these can be used interchangeably.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.