feat: support toggling 'whole file' annotations#149
Conversation
|
Is this the best UX? I wonder what is more common:
If (2) is common, and (1) is rather rare, we should decouple the settings, keep (2) as the sole function of the toggle and allow switching (1) through a command in the command palette and/or through the I'm personally leaning towards that, thoughts @sourcegraph/web @AlicjaSuska ? |
|
I really like this change of cycling through 3 states. I think it's relatively easy to learn. After the first use, there should be no problem imo. I think that your solution @felixfbecker is ok as well but it may be way harder to discover. I would go with @tjkandala 's change 👍 |
| "type": "boolean", | ||
| "default": false | ||
| }, | ||
| "git.blame.decorations": { |
There was a problem hiding this comment.
The other setting should be removed, right?
|
@tjkandala there is a bug: when the extension is 'off' is shouldn't be highlighted anymore. Shown at the end of the video: |
Thanks for spotting this, I think it's because I kept references to the old settings in an attempt to be backwards compatible, but that is a lot more trouble than it's worth. I'll simplify the settings and this should go away |
|
@tjkandala just make sure that the visual pressed state stays correct even for users who were users of git blame before and that it defaults to |
|
@tjkandala checking in - are you working on the fix for the problem @AlicjaSuska pointed out? |
|
Update: "onboarding" users with deprecated settings more gracefully now. Update configuration based on deprecated settings when the new setting, |
The toggle action now cycles through 'none' (no annotations), 'line' (annotations only for selected lines) and 'file' (annotations for all lines).
I tried to make this as backwards compatible as possible, but the first toggle for existing users may be a bit awkward.