This repository was archived by the owner on Feb 22, 2020. It is now read-only.
Filter definitions #50
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This uses a regex to find import statements and omits symbol search results that are defined in files that are not imported. Example https://sourcegraph.com/github.com/sourcegraph/sourcegraph@master/-/blob/cmd/frontend/db/repos.go#L47:65&tab=def
Here's an example where this technique successfully filtered down from ~20 results to a single unique result https://sourcegraph.com/github.com/sourcegraph/sourcegraph@7e72cbf659b10f613acdd22963447e47f174138b/-/blob/cmd/frontend/registry/extensions.go#L219:22
Where this breaks: if the real definition of the token is in a transitively imported package, this will incorrectly omit the result from the list unless there were no results in imported packages. One way to solve that is to walk the imports, but that would be quite slow. Maybe we can index the set of transitive imports somehow so that lookups are fast.