This repository was archived by the owner on Feb 22, 2020. It is now read-only.
Add icon #93
Merged
Add icon #93
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Does this need to be square? |
felixfbecker
approved these changes
Aug 11, 2019
Contributor
Author
|
Heh, yup
|
Contributor
|
Perhaps the webapp CSS should also be fixed so this can't happen |
Contributor
Author
|
👍 changing webapp CSS in https://github.com/sourcegraph/sourcegraph/pull/5161 |
Contributor
Author
|
Squared up the icon so it doesn't look stretched between now and when https://github.com/sourcegraph/sourcegraph/pull/5161 is merged. I'll also make sure other icons I add are square because customer instances don't have https://github.com/sourcegraph/sourcegraph/pull/5161 yet. |
Contributor
|
Good thinking! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Similar to sourcegraph/sourcegraph-typescript#230