Multiple hover and definition requests sent for the same position and blocked on the last result

[felixfbecker]

Go to any pinned position, e.g. https://sourcegraph.com/github.com/angular/angular/-/blob/packages/http/src/http.ts#L116:3

This should only sent a single hover and a single definition request to the extension. However, it sends multiple. lang-typescript just forwards these to the server without deduplication, and sometimes the server is busy and takes long to answer the second request. The UI does not show the hover the second hover and definition requests have returned:

Note how in this scenario, the first request came in at 18:18:58, and the hover could have been shown at 18:19:08, instead it didn't appear until 18:19:43 (ideally the server would be super responsive always but this is simply not always the reality - we should not overload it from our side).

I suspect this is a bug in codeintellify that wasn't noticed before because we used to cache all requests. Extensions can't really do this anymore if they want to work in editors too, and they shouldn't have to add code for this.

cc @sqs @lguychard @ijsnow

[sqs]

This may have been fixed unintentionally by other changes, so try to repro first.

[chrismwendt]

I see 1 hover and 2 definition requests:

There are 4 recv response #??: languageFeatures/$observeDefinition because each one emits a value AND a completion message.

Looking into this now.

[chrismwendt]

Fixing in sourcegraph/codeintellify#92

[chrismwendt]

This bug seems to have reappeared (see sourcegraph/sourcegraph-typescript#246)