Conversation
Codecov Report
@@ Coverage Diff @@
## main #16746 +/- ##
==========================================
- Coverage 52.29% 52.21% -0.08%
==========================================
Files 1699 1705 +6
Lines 84005 84139 +134
Branches 7788 7657 -131
==========================================
+ Hits 43931 43935 +4
- Misses 36201 36332 +131
+ Partials 3873 3872 -1
|
client/web/src/user/settings/codeHosts/UserAddCodeHostsPage.scss
Outdated
Show resolved
Hide resolved
|
|
||
| import CheckCircleIcon from 'mdi-react/CheckCircleIcon' | ||
| import AlertCircleIcon from 'mdi-react/AlertCircleIcon' | ||
| import CircleOutlineIcon from 'mdi-react/CircleOutlineIcon' |
There was a problem hiding this comment.
@quinnkeast I couldn't find the dashed circle in mdi-react. Do you want me to make a custom svg?
There was a problem hiding this comment.
Yes, please do! The dashes are an important visual element for making certain it isn't interpreted as a radio button. We'll also use it in other locations as well.
There was a problem hiding this comment.
I'll make a ticket to do this, I played around but wasn't happy with the TS types for the icon component.
client/web/src/user/settings/codeHosts/UserAddCodeHostsPage.scss
Outdated
Show resolved
Hide resolved
|
@tjkandala Was only able to change initial icon color with Seems like |
felixfbecker
left a comment
There was a problem hiding this comment.
LGTM besides my comments
client/web/src/user/settings/codeHosts/AddCodeHostConnectionModal.tsx
Outdated
Show resolved
Hide resolved
client/web/src/user/settings/codeHosts/UserAddCodeHostsPage.tsx
Outdated
Show resolved
Hide resolved
client/web/src/user/settings/codeHosts/UserAddCodeHostsPage.tsx
Outdated
Show resolved
Hide resolved
|
@artemruts the icon should use the current text color for the fill using the |
@felixfbecker Thank you, Felix! text helper classes work, great solution! |
Description
Fixes #16325 Modified tokens page as per new designs in Figma.
User only changes, side admins still have previous UI.
Demo