Skip to content
This repository was archived by the owner on Sep 30, 2024. It is now read-only.

Point thread-loader at Sourcegraph fork #299

Merged
merged 1 commit into from
Oct 5, 2018
Merged

Point thread-loader at Sourcegraph fork #299

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -198,7 +198,7 @@
"style-loader": "^0.23.0",
"stylelint": "^9.4.0",
"stylelint-formatter-compact": "^1.1.0",
"thread-loader": "^1.2.0",
"thread-loader": "sourcegraph/thread-loader#ddbb570ed8de6a44c94c248adc3486fdd3ef7a0c",
Copy link
Contributor

@felixfbecker felixfbecker Oct 5, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How does a git reference work? If I look at package.json, the main field points to dist/cjs.js, which is not checked into git since its compiled

https://github.com/webpack-contrib/thread-loader/blob/c3366d61cf4621f37483e4e7a1287783eb70277b/package.json#L7

Copy link
Contributor

@ijsnow ijsnow Oct 5, 2018 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was wondering the same thing but CI passed so I looked and the dist directory is checked in. Not best practices but from my understanding, this is temporary. The dist is pretty small.

Copy link
Contributor Author

@kevinburke kevinburke Oct 5, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I pushed another change which checks in the dist folder, it seemed like the easiest way to resolve the issue.

Copy link
Contributor

@felixfbecker felixfbecker Oct 5, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe thread-loader is not used in CI builds and only in dev?

Copy link
Contributor Author

@kevinburke kevinburke Oct 5, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry - The commit referenced in the build there will install a version of the package that has the dist field present.

"ts-loader": "^5.0.0",
"ts-node": "^7.0.1",
"ts-unused-exports": "^2.0.5",
Expand Down
5 changes: 2 additions & 3 deletions yarn.lock
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10666,10 +10666,9 @@ thenify-all@^1.0.0:
dependencies:
any-promise "^1.0.0"

thread-loader@^1.2.0:
thread-loader@sourcegraph/thread-loader#ddbb570ed8de6a44c94c248adc3486fdd3ef7a0c:
version "1.2.0"
resolved "https://registry.yarnpkg.com/thread-loader/-/thread-loader-1.2.0.tgz#35dedb23cf294afbbce6c45c1339b950ed17e7a4"
integrity sha512-acJ0rvUk53+ly9cqYWNOpPqOgCkNpmHLPDGduNm4hDQWF7EDKEJXAopG9iEWsPPcml09wePkq3NF+ZUqnO6tbg==
resolved "https://codeload.github.com/sourcegraph/thread-loader/tar.gz/ddbb570ed8de6a44c94c248adc3486fdd3ef7a0c"
dependencies:
async "^2.3.0"
loader-runner "^2.3.0"
Expand Down