Point thread-loader at Sourcegraph fork #299
Conversation
kevinburke
force-pushed
the
update-thread-loader
branch
from
b33e42d to
075be76
Compare
ijsnow
left a comment
ijsnow
left a comment
There was a problem hiding this comment.
I probably would have went ahead and published this to @sourcegraph/thead-loader on npm but this is fine with me.
package.json
Outdated
There was a problem hiding this comment.
How does a git reference work? If I look at package.json, the main field points to dist/cjs.js, which is not checked into git since its compiled
There was a problem hiding this comment.
I was wondering the same thing but CI passed so I looked and the dist directory is checked in. Not best practices but from my understanding, this is temporary. The dist is pretty small.
There was a problem hiding this comment.
I pushed another change which checks in the dist folder, it seemed like the easiest way to resolve the issue.
There was a problem hiding this comment.
Maybe thread-loader is not used in CI builds and only in dev?
There was a problem hiding this comment.
Sorry - The commit referenced in the build there will install a version of the package that has the dist field present.
If you want to do this that would be great, I'm not sure I have access. |
kevinburke
force-pushed
the
update-thread-loader
branch
3 times, most recently
from
37b5a23 to
48142aa
Compare
The thread-loader package starts several subprocesses. When you send a SIGINT to thread-loader, the subprocesses terminate, but the parent process hangs while waiting for them to send data. We were not listening for the 'end' event in the parent process which meant that the webpack processes would just hang forever. This is a problem because this blocks the shutdown of goreman which means we can have orphan processes and is, in general, a huge hassle when developing the codebase locally. Fix this by listening for an 'end' event, which means we can signal to Webpack that the job terminated with an error, instead of not terminating. This means that SIGINT will actually shut down the process instead of leaving it hanging forever. Fixes sourcegraph/sourcegraph#186. Updates webpack/thread-loader#33. Updates webpack/thread-loader#34. Updates webpack/thread-loader#35. Updates webpack/thread-loader#36.
kevinburke
force-pushed
the
update-thread-loader
branch
from
48142aa to
b107ecf
Compare
The thread-loader package starts several subprocesses. When you send
a SIGINT to thread-loader, the subprocesses terminate, but the parent
process hangs while waiting for them to send data. We were not
listening for the 'end' event in the parent process which meant that
the webpack processes would just hang forever.
Fix this by listening for an 'end' event, which means we can signal to
Webpack that the job terminated with an error, instead of not
terminating. This means that SIGINT will actually shut down the
process instead of leaving it hanging forever.
Updates webpack/thread-loader#33.
Updates webpack/thread-loader#34.
Updates webpack/thread-loader#35.
Updates webpack/thread-loader#36.