This repository was archived by the owner on Sep 30, 2024. It is now read-only.
graphqlbackend: Add API spec for site config history diff#46205
Closed
indradhanush wants to merge 7 commits into
Closed
graphqlbackend: Add API spec for site config history diff#46205indradhanush wants to merge 7 commits into
indradhanush wants to merge 7 commits into
Conversation
indradhanush
force-pushed
the
ig/site-config-diff-api
branch
from
05b4001 to
baa68f3
Compare
indradhanush
commented
Jan 6, 2023
Contributor
Author
There was a problem hiding this comment.
We may be able to reuse this for code host config diff in the future, but we can cross that bridge when we get there.
indradhanush
commented
Jan 6, 2023
Contributor
Author
There was a problem hiding this comment.
This can be just a string from the result of running cmp.Diff on two strings. Check out a working example of what this might look here: https://go.dev/play/p/_ajoz7jQ8xd
Contributor
Author
There was a problem hiding this comment.
Also was not able to reuse type Diff because it expects a GitRevisionRange which won't work for us here.
6 tasks
indradhanush
force-pushed
the
ig/site-config-diff-api
branch
from
be3a664 to
bc975e4
Compare
indradhanush
force-pushed
the
ig/persist-author-site-config
branch
2 times, most recently
from
e601a62 to
60caff3
Compare
indradhanush
changed the base branch from
main
to
main-dry-run/ig/persist-author-site-config
indradhanush
changed the base branch from
main-dry-run/ig/persist-author-site-config
to
main
indradhanush
force-pushed
the
ig/site-config-diff-api
branch
from
bc975e4 to
c599fa8
Compare
indradhanush
commented
Jan 9, 2023
indradhanush
commented
Jan 9, 2023
mrnugget
reviewed
Jan 9, 2023
Contributor
There was a problem hiding this comment.
Suggested change
| A list of diffs to depict what changed since the previous version of this | |
| EXPERIMENTAL: A list of diffs to depict what changed since the previous version of this |
indradhanush
force-pushed
the
ig/site-config-diff-api
branch
from
bfc73c1 to
4c323ea
Compare
Contributor
Author
|
After review, the API spec is now final. Closing this PR to move forward with implementation and follow up with a new PR. Thank you @mrnugget! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #46031.
What
An API to return the diff between two consecutive entries in the
critical_and_site_configtable which stores the entire site config as a new row each time it is updated.Why
We want to show the history of changes to the site config in the site-admin UI as a site-admin UX improvement.
Test plan