wolfi: cadvisor entrypoint

[davejrt]

Fixes the cadvisor entry point, which was being split onto new lines, meaning we were dropping some metrics like memory as reported by @michaellzc.

As part of the testing I tried just downloading the binary from github, rather than building it from scratch. That didn't turn out to the final solution so that's an OPTIONAL leave in, but to me seems like an easier approach than compiling ourselves.

With a rebuild of the base image we're also now running cadvisor 0.47.3

Old (working):

            "Entrypoint": [
                ....
                "-enable_metrics=cpu,diskIO,memory,network",
                ....
            ],

New (broken):

 "Entrypoint": [
                "/usr/bin/cadvisor",
                ....
                "-enable_metrics=cpu",
                "diskIO",
                "memory",
                "network",
                ....

Closes https://github.com/sourcegraph/devx-support/issues/68

Test plan

Tested on scaletesting.sgdev.org

vs sourcegraph.com

[sourcegraph-bot]

Codenotify: Notifying subscribers in CODENOTIFY files for diff 76630f0...9a7d438.

Notify	File(s)
@bobheadxi	docker-images/cadvisor/BUILD.bazel docker-images/cadvisor/entrypoint.sh

[willdollman]

The current wolfi-images/cadvisor.yaml actually uses the chainguard cadvisor package rather than our built-from-source version. I switched it during development as Chainguard added cadvisor to their repo but didn't remove our custom config.

If you want to switch back to our custom package, you can change this line to cadvisor@sourcegraph

[willdollman]

See note about Sourcegraph vs Wolfi cadvisor package, but if it's working as-is then I guess it doesn't need to be changed. Thanks for investigating @davejrt 🎉

[davejrt]

See note about Sourcegraph vs Wolfi cadvisor package, but if it's working as-is then I guess it doesn't need to be changed. Thanks for investigating @davejrt 🎉

Both with the same result...so it's better we continue using the chainguard version. They released 0.47.3 yesterday so I've rebuilt and upgraded us, retested and everything looks good.

I'm removing the reference to the package to avoid any confusion going forward.

[michaellzc]

thank you!

can we backport this to 5.1 as well?

[github-actions]

The backport to 5.1 failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-5.1 5.1
# Navigate to the new working tree
cd .worktrees/backport-5.1
# Create a new branch
git switch --create backport-54809-to-5.1
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 054439411834940cf45f1e5afa4e5c72722d439d
# Push it to GitHub
git push --set-upstream origin backport-54809-to-5.1
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-5.1

Then, create a pull request where the base branch is 5.1 and the compare/head branch is backport-54809-to-5.1.