This repository was archived by the owner on Sep 30, 2024. It is now read-only.
gitserver: change the way repo name is checked for git command recording. #55111
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ing.
Previously, we checked for a substring, but it breaks in cases where given repo name is a prefix for another repo names, e.g.: "repo/a" is included, but "repo/ab" and "repo/a-1" are included too, because of the check.
This commit changes this behaviour to check for the suffix instead, which is not perfect, but judging from local testing and how the repos are named ("orgName/repoName"), this check will filter out most repos which were previously included by mistake.
Precise implementation requires a lot of effort to propagate repo names through the recording stack and can be done later.
Test plan:
Local sg run and test that repos with matching prefix are not recorded.
sashaostrikov
added
the
team/source
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, we checked for a substring, but it breaks in cases where given repo name is a prefix for another repo names, e.g.: "repo/a" is included, but "repo/ab" and "repo/a-1" are included too, because of the check.
This commit changes this behaviour to check for the suffix instead, which is not perfect, but judging from local testing and how the repos are named ("orgName/repoName"), this check will filter out most repos which were previously included by mistake.
Precise implementation requires a lot of effort to propagate repo names through the recording stack and can be done later.
Test plan:
Local sg run and test that repos with matching prefix are not recorded.
Part of https://github.com/sourcegraph/sourcegraph/issues/55058