This repository was archived by the owner on Sep 30, 2024. It is now read-only.
[Backport 5.1] Enable "Test connection" for Perforce code hosts #56792
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* fill out `CheckConnection` and mark Perforce as able to check connections. * Refactor the connection test to not rely on IsCloneable Because connecting to Perforce requires using the `p4` CLI binary, which is on `gitserver`, we're using the Perforce VCS Syncer to do the connection check. Add a method to the VCS syncer for Perforce specifically for checking the connection instead of hacking a solution that re-uses IsCloneable, which requires a valid depot. Adding another func won't break composition with VCSSyncer. * update comment on CheckConnection * add a 10-second timeout for the connection test 10 seconds is somewhat arbitrary, but seems like enough time to allow for various connection issues, whle not being too long for the frontend. * Change from directly using the syncer to making an RPC call to gitserver because the call to CheckConnection comes fro mthe frontend, where `p4` is not available. (cherry picked from commit b1fd4da)
Contributor
|
Codenotify: Notifying subscribers in CODENOTIFY files for diff 7f7e6c9...4cf29e7.
|
Contributor
|
@peterguy is this change changelog-worthy? (looks like so). If yes, would you mind adding an entry to https://github.com/sourcegraph/sourcegraph/blob/main/CHANGELOG.md#unreleased-519-planned-release-date-september-20-2023 first? |
Contributor
unknwon
approved these changes
Sep 20, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enable the "Test connection" button in the code host page UI
Test plan
Click the "Test connection" button in the code host connection UI. A message with an orange border will display, "Checking code host connection..." and then "Code host is reachable" should display with a green border.
<img width="1148" alt="Screenshot 2023-09-15 at 14 17 00" src="https://github.com/sourcegraph/sourcegraph/assets/129280/a4c30d9b-ceff-4afe-b966-f7bd1c0385d9">
Backport b1fd4da from #56697