This repository was archived by the owner on Sep 30, 2024. It is now read-only.
[Backport 5.2] revert p4-fusion to 1.12#57114
Merged
Merged
Conversation
encountered sigsegv errors with 1.13 (cherry picked from commit 8995807)
Contributor
keegancsmith
approved these changes
Sep 28, 2023
Contributor
|
@keegancsmith - hmm, looks like CI has a valid failure about dependency version locking? |
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Occasional core dumps with 1.13, most of them SIGSEGV
core dumps do not happen all of the time, but this command run on
gitserverreliably reproduces them:Note that
<perforce user>needs to be replaced with a value user for the Perforce instance,<user ticket>needs to be replaced with the correct ticket for the user,<perforce host>replaced with the actual Perforce host + port #, and<depot name>with the depot name or path, including the leading//and trailing/.Test plan
Connect to
gitservervia a terminal and run the above command. If usingp4-fusion1.13, it will fail some or all of the time with core dumps.Example output:
If using
p4-fusion1.12, the output will be allreturn code: 0, like this one:Not that it helps here, but changing
lookAheadto1seems to stop the core dumps, at the cost of cloning speed.Backport 8995807 from #57113