This repository was archived by the owner on Jun 7, 2022. It is now read-only.
use registerLocationProvider for impls, remove deprecated registerImplementationProvider #132
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Mar 14, 2019
chrismwendt
approved these changes
Mar 14, 2019
sqs
added a commit
to sourcegraph/sourcegraph-public-snapshot
that referenced
this pull request
Mar 16, 2019
…2733) Previously, a TypeScript cast `as PanelViewWithComponent` resulted in panel views (that used a custom location provider registered with `registerLocationProvider`) having an incorrectly typed `locationProvider` value. This meant that using a panel view with a custom location provider would throw a JavaScript error. Depends on sourcegraph/sourcegraph#1697 Related: - sourcegraph/sourcegraph-go#47 - sourcegraph/sourcegraph-typescript#132
sqs
added a commit
to sourcegraph/sourcegraph-go
that referenced
this pull request
Mar 16, 2019
Previously, the call to `registerLocationProvider('id', ...` was a noop. The location provider was not actually used anywhere. It needs to be added to a panel to be shown.
- Depends on sourcegraph/sourcegraph#2733
- Depends on #46
Unlike for TypeScript (see note in sourcegraph/sourcegraph-typescript#132), Go ifaces/impls were already broken, so this should be merged immediately even though sourcegraph/sourcegraph#2733 is not yet merged and released.
…lementationProvider `registerImplementationProvider` is deprecated and is being removed in 3.2 (see sourcegraph/sourcegraph#1697). This uses the new registerLocationProvider.
sqs
added a commit
to sourcegraph/sourcegraph-public-snapshot
that referenced
this pull request
Mar 16, 2019
…2733) Previously, a TypeScript cast `as PanelViewWithComponent` resulted in panel views (that used a custom location provider registered with `registerLocationProvider`) having an incorrectly typed `locationProvider` value. This meant that using a panel view with a custom location provider would throw a JavaScript error. Depends on sourcegraph/sourcegraph#1697 Related: - sourcegraph/sourcegraph-go#47 - sourcegraph/sourcegraph-typescript#132
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
registerImplementationProvideris deprecated and is being removed in 3.2 (see https://github.com/sourcegraph/sourcegraph/pull/1697). This uses the new registerLocationProvider.(See the note on backcompat for why it needs to also keep the call to
registerImplementationProviderfor now.)Related to (but does not depend on) https://github.com/sourcegraph/sourcegraph/pull/2733