-
Notifications
You must be signed in to change notification settings - Fork 5
Activation refactor #308
Activation refactor #308
Conversation
b1a1b23 to
c5c166c
Compare
c5c166c to
a6c21be
Compare
Updated. |
chrismwendt
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I verified the hover/def/ref behavior with/without LSIF/LSP remains unchanged (same as sourcegraph/sourcegraph-go#117 (review))
| ctx, | ||
| documentSelector, | ||
| handlerArgs, | ||
| config.value['typescript.serverUrl'] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note that before, you could change the config during a session and it would be considered. Now it seems the config is read only once during activation. I think this could cause problems in particular in the browser extension, where extensions are run in the background page and are not necessarily re-activated just because the page got reloaded.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah you're right - I missed that. We used to check on each function invocation. I'll update the new API to support doing this dynamically.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.

This PR cleans up the init code after sourcegraph/code-intel-extensions#198.
This removes all LSIF and search-based logic and instead delegates to the
activateCodeIntelfunction, passing it only the language-server specific logic.This PR will be followed by a major cleanup.