vendor in lib from sourcegraph #1202
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Requires one fix due to an API change in lib
Member
Author
|
Note I haven't actually tested if the script will correctly update ./lib when run on a new version of lib. I have my doubts, but thought we could tackle it when we need to do that. @eseliger you asked for latest lib, you now have it :) |
Member
|
nice! thank you 🙏 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We no longer need to point at an old version of lib. Instead we create a script which copies over the subset of lib we use. This is a temporary solution. We likely need to publish this library somewhere as open source instead.
Test Plan: go test ./...