Skip to content

Fix log message when action did not produce any results #148

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 2, 2020
Merged

Fix log message when action did not produce any results #148

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions cmd/src/actions_exec_logger.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -73,12 +73,14 @@ func (a *actionLogger) ActionFailed(err error, patches []CampaignPlanPatch) {
} else {
yellow.Fprintf(os.Stderr, "✗ Action failed with %d errors.\n", len(perr))
}
} else {
} else if err != nil {
if len(patches) > 0 {
yellow.Fprintf(os.Stderr, "✗ Action produced %d patches but failed with error: %s\n\n", len(patches), err)
} else {
yellow.Fprintf(os.Stderr, "✗ Action failed with error: %s\n\n", err)
}
} else {
grey.Fprintf(os.Stderr, "✗ Action did not produce any patches.\n\n")
}
}

Expand Down Expand Up @@ -106,7 +108,7 @@ func (a *actionLogger) RepoCacheHit(repo ActionRepo, patchProduced bool) {
return
}

fmt.Fprintf(os.Stderr, "%s -> Cached result found: no diff produced for this repository.\n", green.Sprint(repo.Name))
fmt.Fprintf(os.Stderr, "%s -> Cached result found: no diff produced for this repository.\n", grey.Sprint(repo.Name))
}
}

Expand Down