Skip repositories being cloned in action exec instead of returning error #173
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes https://github.com/sourcegraph/sourcegraph/issues/9149 When a repository is being cloned while we execute the `scopeQuery` of an action, the GraphQL query returns something like this: { "errors": [ { "message": "repository does not exist: github.com/sourcegraphtest/alwayscloningtest", "path": [ "search", "results", "results", 2, "defaultBranch" ] } ], "data": { "search": { "results": { "results": [ { "__typename": "Repository", "id": "UmVwb3NpdG9yeTox", "name": "github.com/sourcegraph/automation-testing", "defaultBranch": { "name": "refs/heads/master", "target": { "oid": "3a0d12026c1349c4aefb712145433cc26c330a06" } } }, { "__typename": "Repository", "id": "UmVwb3NpdG9yeTozOTU=", "name": "github.com/sourcegraphtest/AlwaysCloningTest", "defaultBranch": null } ] } } } } There is an error for `AlwaysCloningTest` but `AlwaysCloningTest` is also being returned in the data, except that its `defaultBranch` is `null`. So instead of returning an error when one of the repositories is being cloned and doesn't have a default branch, we simply check for the existence of the `defaultBranch` attribute and if it's not there, we skip the repository.
ryanslade
approved these changes
Apr 3, 2020
|
nice 🎊 Reminder to myself: port this to |
mrnugget
added
the
action-exec
scjohns
pushed a commit
that referenced
this pull request
Apr 24, 2023
…ror (#173) This fixes https://github.com/sourcegraph/sourcegraph/issues/9149 When a repository is being cloned while we execute the `scopeQuery` of an action, the GraphQL query returns something like this: { "errors": [ { "message": "repository does not exist: github.com/sourcegraphtest/alwayscloningtest", "path": [ "search", "results", "results", 2, "defaultBranch" ] } ], "data": { "search": { "results": { "results": [ { "__typename": "Repository", "id": "UmVwb3NpdG9yeTox", "name": "github.com/sourcegraph/automation-testing", "defaultBranch": { "name": "refs/heads/master", "target": { "oid": "3a0d12026c1349c4aefb712145433cc26c330a06" } } }, { "__typename": "Repository", "id": "UmVwb3NpdG9yeTozOTU=", "name": "github.com/sourcegraphtest/AlwaysCloningTest", "defaultBranch": null } ] } } } } There is an error for `AlwaysCloningTest` but `AlwaysCloningTest` is also being returned in the data, except that its `defaultBranch` is `null`. So instead of returning an error when one of the repositories is being cloned and doesn't have a default branch, we simply check for the existence of the `defaultBranch` attribute and if it's not there, we skip the repository.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes https://github.com/sourcegraph/sourcegraph/issues/9149
When a repository is being cloned while we execute the
scopeQueryofan action, the GraphQL query returns something like this:
There is an error for
AlwaysCloningTestbutAlwaysCloningTestisalso being returned in the data, except that its
defaultBranchisnull.So instead of returning an error when one of the repositories is being
cloned and doesn't have a default branch, we simply check for the
existence of the
defaultBranchattribute and if it's not there, weskip the repository.