Skip to content

Deprecate config file in favour of env variables #205

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 27, 2020
Merged

Deprecate config file in favour of env variables #205

merged 1 commit into from
May 27, 2020

Conversation

@ryanslade
Copy link
Contributor

@ryanslade ryanslade commented May 26, 2020 •
edited
Loading

We still read from the config file but it has been undocumented so
that we can remove it at a later point.

Users should instead use the SRC_ACCESS_TOKEN and
SRC_ENDPOINT environment variables.

Part of: #156

@ryanslade
Deprecate config file
bfb232b 
We'll still read from the config file but it has been undocumented so
that we can remove it at a later point.
@ryanslade ryanslade requested review from emidoots and mrnugget and removed request for mrnugget May 26, 2020 13:14
@ryanslade
Copy link
Contributor Author

I removed the docs, would it have been better to add a DEPRECATED warning instead?

mrnugget
mrnugget approved these changes May 27, 2020
View reviewed changes
Copy link
Contributor

@mrnugget mrnugget left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it's fine to deprecate it, as long as the PR description/title here contains enough information, since that will show up in the changelog.

@ryanslade ryanslade changed the title Deprecate config file Deprecate config file in favour of env variables May 27, 2020
@ryanslade ryanslade merged commit 361a8de into master May 27, 2020
@mrnugget mrnugget mentioned this pull request Jun 9, 2020
Open
@sqs sqs mentioned this pull request Sep 15, 2020
Merged
scjohns pushed a commit that referenced this pull request Apr 24, 2023
@ryanslade
Deprecate config file (#205)
57a72e5 
We still read from the config file but it has been undocumented so
that we can remove it at a later point.

Users should instead use the SRC_ACCESS_TOKEN and
SRC_ENDPOINT environment variables.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mrnugget mrnugget mrnugget approved these changes

@emidoots emidoots Awaiting requested review from emidoots

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@ryanslade @mrnugget