Display a progress bar in verbose mode #209
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mrnugget
reviewed
May 28, 2020
Display patches and failed steps instead of jobs Be more explicit about when we log to the repo loggers Move more display logic into the logger Don't hardcode number of spaces when clearing progress
progress now keeps track of progress state. progressWriter is a writer that uses current progress to append a progress bar.
|
@mrnugget PTAL |
|
New look:
|
mrnugget
approved these changes
Jun 2, 2020
There was a problem hiding this comment.
👍 I like this version much more.
I left some comments with some ideas and suggestions:
- I don't think we need to have a "triangle dependency" between
progress/progressWriterandactionLogger.actionLoggerdoesn't need to know about both, I think. Maybe we can useio.Writerto make that clearer. See comment. - I don't like the parentheses in the formatting of the progress. Suggested some other formatting for the message.
Co-authored-by: Thorsten Ball <mrnugget@gmail.com>
Co-authored-by: Thorsten Ball <mrnugget@gmail.com>
scjohns
pushed a commit
that referenced
this pull request
Apr 24, 2023
* Display a progress bar when running in verbose mode * Cleanups after code review Display patches and failed steps instead of jobs Be more explicit about when we log to the repo loggers Move more display logic into the logger Don't hardcode number of spaces when clearing progress * Split progress and writer progress now keeps track of progress state. progressWriter is a writer that uses current progress to append a progress bar. * Update cmd/src/actions_exec_logger.go Co-authored-by: Thorsten Ball <mrnugget@gmail.com> * Update cmd/src/actions_exec_logger.go Co-authored-by: Thorsten Ball <mrnugget@gmail.com> * Move progress methods * Tweak progress bar labels * Remove dependency between actionLogger and progressWriter Co-authored-by: Thorsten Ball <mrnugget@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #190