-
Notifications
You must be signed in to change notification settings - Fork 69
migrate Configuration usage to Settings #211
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approve to unblock, but I think before you merge, you should rename the other variable names too so they reflect the new state.
cmd/src/config.go
Outdated
|
|
||
| const configurationSubjectFragment = ` | ||
| fragment ConfigurationSubjectFields on ConfigurationSubject { | ||
| fragment ConfigurationSubjectFields on SettingsSubject { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To avoid others being confused by this in the future, let's make the naming consistent 🙂
| fragment ConfigurationSubjectFields on SettingsSubject { | |
| fragment SettingsSubjectFields on SettingsSubject { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I dug a bit deeper and the changes turned out to be pretty far-reaching - all the Configuration fields are listed as deprecated, and the shape of some things have changed, so I went ahead and made everything Settings: 9a39f3e
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work!
|
Once you merge, please create a release following these instructions: https://github.com/sourcegraph/src-cli/blob/master/DEVELOPMENT.md#releasing |
|
Good stuff, thanks @bobheadxi! |
closes https://github.com/sourcegraph/sourcegraph/issues/10419
looks like
ConfigurationSubjectwas removed a while back, andSettingsSubjecthas replaced ita variety of other
Configuration-related fields have been listed as deprecated, so I've gone ahead and migrated them to useSettings