Move action execution related code to campaigns package #230
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mrnugget
force-pushed
the
campaigns-pkg
branch
2 times, most recently
from
3c09b66 to
5e5ef98
Compare
eseliger
approved these changes
Jun 23, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Opinions on this?
I think the code related to campaigns-specific functionality was sprawling and moving it to its own package makes API boundaries and dependencies clearer.
This is a first step that very stupidly capitalizes identifiers to export them and passes dependencies into the package (
cfg.Endpoint,cfg.AccessToken). If we're happy with having a separate package, we can rename things (which we'll do anyway with the new flow) and possibly create other subpackages.(Stacked on top of #229)