Update jsonx dependency #233
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
28 tasks
mrnugget
approved these changes
Jun 25, 2020
LawnGnome
force-pushed
the
aharvey/update-jsonx
branch
from
f263eaf to
7a50e63
Compare
|
Rebased after landing sourcegraph/jsonx#7 and sourcegraph/jsonx#8, which will allow us both to fix sourcegraph/sourcegraph#10541 and set us up to review and land #232. |
mrnugget
approved these changes
Jun 30, 2020
scjohns
pushed a commit
that referenced
this pull request
Apr 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is the last step that fixes sourcegraph/sourcegraph#10541 in full.
However, if we decide we'd like #232, we should wait and get sourcegraph/jsonx#8 and #232 merged first, then I can update this again to that version of jsonx.