campaigns: support applyCampaigns #260
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
45 tasks
eseliger
force-pushed
the
aharvey/campaign-apply-prototype
branch
from
5ab9c6c to
e9a8ad2
Compare
This gives us some basic primitives to output structured, human readable information from commands. This is currently intended only for the campaigns work taking place in #260, but also gives us options for additional functionality elsewhere, such as internal/api. This is somewhat duplicative with things that we currently have in cmd/src and internal/campaigns; I intend to gradually clean those up as time permits.
LawnGnome
force-pushed
the
aharvey/campaign-apply-prototype
branch
from
8f2eaa5 to
9ac65fb
Compare
mrnugget
approved these changes
Aug 20, 2020
There was a problem hiding this comment.
👏 This is really well architected, thank you! Good eye for how to slice up and refactor existing code 🙂
I bet output was fun to write 😄
One request for this iteration: I'd appreciate some documentation (in sourcegraph/sourcegraph I think) that describes the semantics behind campaigns apply: how the list of repositories is generated, how the shell command is run in the container, etc.
mrnugget
reviewed
Aug 20, 2020
|
Created a ticket for something I noticed while trying out this branch: https://github.com/sourcegraph/sourcegraph/issues/13172 I don't think it needs to be a part of this PR but we (and also not necessarily you, Adam) need to tackle this in this iteration. |
|
Before merging: run |
Co-authored-by: Thorsten Ball <mrnugget@gmail.com>
Co-authored-by: Thorsten Ball <mrnugget@gmail.com>
Co-authored-by: Thorsten Ball <mrnugget@gmail.com>
Co-authored-by: Thorsten Ball <mrnugget@gmail.com>
Co-authored-by: Thorsten Ball <mrnugget@gmail.com>
Co-authored-by: Thorsten Ball <mrnugget@gmail.com>
Co-authored-by: Thorsten Ball <mrnugget@gmail.com>
Except that implies a certain level of skill and expertise that isn't evident here, so this is more word-banging-on-hot-metal-and-trying-not-to-set-the-workshop-on-fire.
eseliger
reviewed
Aug 21, 2020
52 tasks
scjohns
pushed a commit
that referenced
this pull request
Apr 24, 2023
Co-authored-by: Thorsten Ball <mrnugget@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements the new campaign spec workflow, most notably
src campaigns apply. Therefore, it will close sourcegraph/sourcegraph#12333, close sourcegraph/sourcegraph#11350, and close #259.Note that this PR includes #268, but that should be reviewed separately.
Here's a GIF: