Skip to content

Conversation

@chrispine
Copy link

@chrispine chrispine commented Sep 1, 2020

This is the src-cli side of the fix for #12769. (back-end PR)

It implements the first part of RFC 229, so campaign specs can have changeset templates that now look like:

changesetTemplate:
  title: Hello World
  body: My first campaign
  branch: hello-world # Push the commit to this branch.
  commit:
    message: Append Hello World to all README.md files
    author:
      name: Chris Pine
      email: chrispine@sourcegraph.com
  published: true

Issues

  • I don't know how to say "this version of src-cli goes with that version of the back-end".

Future work

  • Consider: instead of just going with the default author, check for local git config and use that. (But does that behave in ways we don't like: if I create a campaign without specifying an author, then you modify the campaign spec on your machine and apply it... would it change the commit author? Would we want it to?)

Copy link
Contributor

@LawnGnome LawnGnome left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

I think the only other thing we would need is a changelog entry noting the extra fields. Beyond that, 👍.

I don't know how to say "this version of src-cli goes with that version of the back-end".

We discussed this in our sync today, and the answer is srccli.MinimumVersion.

@chrispine chrispine changed the title WIP: campaigns: allow user to set git commit author campaigns: allow user to set git commit author Sep 9, 2020
@chrispine chrispine marked this pull request as ready for review September 9, 2020 17:36
@chrispine chrispine merged commit 7f6cbd1 into main Sep 9, 2020
@chrispine chrispine deleted the cp/campaigns-author-details branch September 9, 2020 17:53
scjohns pushed a commit that referenced this pull request Apr 24, 2023
* add campaigns git commit author data

* updated CHANGELOG
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants