Skip repos without default branch #312
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These are usually empty repos with 0 branches.
LawnGnome
approved these changes
Sep 9, 2020
There was a problem hiding this comment.
This looks good.
In terms of logging, I'm on the fence. We could extend ResolveRepositories() to return a third array of skipped repositories, but we probably wouldn't surface that except when the user is calling src campaign validate, which might be too hidden for the normal case.
Let's leave it like this for now and see if it's confusing in practice.
scjohns
pushed a commit
that referenced
this pull request
Apr 24, 2023
These are usually empty repos with 0 branches.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These are usually empty repos with 0 branches.
Not sure if we would want to log those?
Closes #293