Allow setting temp dir used by campaigns through flag/env var #318
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This addresses a customer report in which `src campaigns apply` couldn't be run in CI because the docker-in-docker setup prohibits mounting `/tmp` into containers. It also fixes parts of #316, since the temporary directory is also where the logs are stored, but we might want to split those locations up (in case a user wants to keep logs but not inside the temporary directory).
eseliger
reviewed
Sep 14, 2020
Co-authored-by: Erik Seliger <erikseliger@me.com>
Co-authored-by: Adam Harvey <aharvey@sourcegraph.com>
scjohns
pushed a commit
that referenced
this pull request
Apr 24, 2023
* Allow setting temp dir used by campaigns through flag/env var This addresses a customer report in which `src campaigns apply` couldn't be run in CI because the docker-in-docker setup prohibits mounting `/tmp` into containers. It also fixes parts of #316, since the temporary directory is also where the logs are stored, but we might want to split those locations up (in case a user wants to keep logs but not inside the temporary directory). * Update cmd/src/campaigns_common.go Co-authored-by: Erik Seliger <erikseliger@me.com> * Update cmd/src/campaigns_common.go Co-authored-by: Adam Harvey <aharvey@sourcegraph.com> * Fall back to os.TempDir in campaignsDefaultTempDirPrefix Co-authored-by: Erik Seliger <erikseliger@me.com> Co-authored-by: Adam Harvey <aharvey@sourcegraph.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This addresses a customer report in which
src campaigns applycouldn'tbe run in CI because the docker-in-docker setup prohibits mounting
/tmpinto containers.It also fixes parts of
#316, since the temporary
directory is also where the logs are stored, but we might want to split
those locations up (in case a user wants to keep logs but not inside the
temporary directory).