Fix regression and clean up log files again #319
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
While looking into how we store ZIP files I realised that log files are not cleaned up. That's not a big issue, since `/tmp` is cleaned up by the OS, but it's still a regression and not what we intended. Digging deeper I ended up starting at the previous for much too long before realising that the cleanup code was simply missing :)
chrispine
approved these changes
Sep 18, 2020
scjohns
pushed a commit
that referenced
this pull request
Apr 24, 2023
While looking into how we store ZIP files I realised that log files are not cleaned up. That's not a big issue, since `/tmp` is cleaned up by the OS, but it's still a regression and not what we intended. Digging deeper I ended up starting at the previous for much too long before realising that the cleanup code was simply missing :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While looking into how we store ZIP files I realised that log files are
not cleaned up. That's not a big issue, since
/tmpis cleaned up bythe OS, but it's still a regression and not what we intended.
Digging deeper I ended up starting at the previous for much too long
before realising that the cleanup code was simply missing :)