release: add a note about DEVELOPMENT.md #349
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I'm not saying I forgot to check the checklist in DEVELOPMENT.md before releasing today, but... uh, I'm not saying I _didn't_ forget, either.
emidoots
reviewed
Oct 13, 2020
release.sh
Outdated
| #!/usr/bin/env bash | ||
|
|
||
| # If you haven't already read DEVELOPMENT.md, please stop and do so. Running | ||
| # this script is _not_ the first thing you need to do to make a release. |
There was a problem hiding this comment.
Can you make this a prompt instead? "Have you read DEVELOPMENT.md first? [y/N]"
There was a problem hiding this comment.
haha, sorry, that's not exactly what I meant - I mean a Bash prompt for yes/no in case people run this script without reading the comments you have here.
e.g. https://github.com/sourcegraph/syntect_server/blob/master/publish.sh#L42-L49
There was a problem hiding this comment.
That makes more sense! Updated. 😄
emidoots
approved these changes
Oct 13, 2020
eseliger
approved these changes
Oct 13, 2020
scjohns
pushed a commit
that referenced
this pull request
Apr 24, 2023
I'm not saying I forgot to check the checklist in DEVELOPMENT.md before releasing today, but... uh, I'm not saying I _didn't_ forget, either.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm not saying I forgot to check the checklist in DEVELOPMENT.md before releasing today, but... uh, I'm not saying I didn't forget, either.