Print only status bars that have been activated #351
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes #348 by changing the behaviour of the `progressWithStatusBarsTTY` to only print status bars that have been updated/reset. It removes the placeholder label "Starting worker..." and simply doesn't display status bars that don't have a value yet.
eseliger
approved these changes
Oct 14, 2020
scjohns
pushed a commit
that referenced
this pull request
Apr 24, 2023
This fixes #348 by changing the behaviour of the `progressWithStatusBarsTTY` to only print status bars that have been updated/reset. It removes the placeholder label "Starting worker..." and simply doesn't display status bars that don't have a value yet.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #348 by changing the behaviour of the
progressWithStatusBarsTTYto only print status bars that have beenupdated/reset.
It removes the placeholder label "Starting worker..." and simply doesn't
display status bars that don't have a value yet.
@LawnGnome can you maybe test this too? I tried to replicate different scenarios (cached, uncached, subset cached, more than numProcesses, less than numProcesses) but I'm not sure whether I caught your bug.