Show failed tasks as errors in statusbars #355
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eseliger
approved these changes
Oct 16, 2020
No real idea off the top of my head but I also didn't find it too strange. |
|
Since there are no opposing voices, let's merge it then and see what happens. |
|
Late to the party, but I think it's fine too. 🥳 |
scjohns
pushed a commit
that referenced
this pull request
Apr 24, 2023
* Show failed tasks as errors in statusbars * Change formatting of status bar error * Add changelog
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Yesterday I noticed that when executing steps fails in a repository we simply show "No changes" in the status bars. If you execute steps in a lot of repositories that means you'll need to wait until all of them are finished to get feedback on whether one of them failed.
This changes the behaviour from this
to this:
I'm not super happy with the
StatusText()andSingleLineError()methods and how to best interface them, but then again I never found wrapped errors easy to manage. If you have any ideas: let me know!