Skip to content

Conversation

@eseliger
Copy link
Member

This can cause unexpected git behavior, like a different diff tool, ANSI coloring in the diff and probably other bad magic.

Closes #371

This can cause unexpected git behavior, like a different diff tool, ANSI coloring in the diff and probably other bad magic.
@eseliger eseliger requested a review from a team November 11, 2020 02:07
Copy link
Contributor

@mrnugget mrnugget left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SWEET! Yes! That's what I call a "nice catch"!

@mrnugget
Copy link
Contributor

I added a changelog entry and am going to merge this and cut a release.

@mrnugget mrnugget merged commit 2cae477 into main Nov 11, 2020
@mrnugget mrnugget deleted the es/no-git-config branch November 11, 2020 08:44
scjohns pushed a commit that referenced this pull request Apr 24, 2023
* Don't use git config that might be present on the host

This can cause unexpected git behavior, like a different diff tool, ANSI coloring in the diff and probably other bad magic.

* Try setting committer name as well

* Add changelog entry

* Update changelog

Co-authored-by: Thorsten Ball <mrnugget@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Local git config may break campaigns

3 participants