Fix panic when search yields repo and file matches in same repo #385
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes #382 by fixing a regression that was introduced by #361. When the search queries defined in a campaign spec yielded a repository match result and file match results in the same repository, in that order, the code would crash because of an uninitialized map. The code here fixes it by always initializing the map. I also added a test that reproduces the behaviour and documents how we turn multiple search results into a list of repositories.
scjohns
pushed a commit
that referenced
this pull request
Apr 24, 2023
This fixes #382 by fixing a regression that was introduced by #361. When the search queries defined in a campaign spec yielded a repository match result and file match results in the same repository, in that order, the code would crash because of an uninitialized map. The code here fixes it by always initializing the map. I also added a test that reproduces the behaviour and documents how we turn multiple search results into a list of repositories.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #382 by fixing a regression that was introduced by #361.
When the search queries defined in a campaign spec yielded a repository
match result and file match results in the same repository, in that
order, the code would crash because of an uninitialized map.
The code here fixes it by always initializing the map.
I also added a test that reproduces the behaviour and documents how we
turn multiple search results into a list of repositories.