Snapshot test the terminal UI #400
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
keegancsmith
reviewed
Dec 1, 2020
| column int | ||
| } | ||
|
|
||
| func (t *ttyBuf) Write(b []byte) (int, error) { |
|
btw. I know that "test coverage" itself doesn't mean a lot, but with the latest commit this bumps the test coverage for |
LawnGnome
approved these changes
Dec 1, 2020
scjohns
pushed a commit
that referenced
this pull request
Apr 24, 2023
* Hacky integration test for CampaignProgressPrinter * Clean up ttyBuf * Force width and height in integration test * For now: skip on Windows * Add completed diff to progress printer test * Print again to make sure that the output is the same * Sort filenames before printing diff summary * Fix missing clearCurrentLine call * Always create a new line on newline character * Be more defensive in ttyBuf * Use stable timestamps in test * Clean up duplicated default opts * Make handling of no-spinner consistent
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I started with one thought: "I just wish I had one test to make sure that this whole thing [the terminal UI] doesn't blow up every time I make a change" What I ended with is this. It includes a tiny VT100 "emulator".
And here's the kicker: I actually like this. It's fast to run and easy to extend and it gives me confidence that the basic rendering functionality works. Of course, the hacky injections need to be cleaned up before merging. And maybe we can get it to pass on Windows.
Opinions?
(This fixes https://github.com/sourcegraph/sourcegraph/issues/16330)