Skip to content

Conversation

@eseliger
Copy link
Member

This fixes us not using any authentication in the src version command, because the api.Client adds the Authorization header to the request automatically

This fixes us not using any authentication in the src version command, because the api.Client adds the Authorization header to the request automatically
@eseliger eseliger added bug Something isn't working team/code-search labels Dec 16, 2020
@eseliger eseliger requested review from a team and emidoots December 16, 2020 21:22
Copy link
Contributor

@LawnGnome LawnGnome left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is probably worth a changelog entry, but otherwise this LGTM.

@eseliger eseliger merged commit d12fcd4 into main Dec 16, 2020
@eseliger eseliger deleted the es/use-auth-version branch December 16, 2020 21:30
Copy link

@chrispine chrispine left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the quick turnaround!

scjohns pushed a commit that referenced this pull request Apr 24, 2023
This fixes us not using any authentication in the src version command, because the api.Client adds the Authorization header to the request automatically.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working team/code-search

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants